(feat) O3-3007: Add support for saving patient identifiers in forms #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
changed the title
samuelmale
reviewed
Apr 23, 2024
kajambiya
force-pushed
the
petienrIfentifier
branch
from
0de866e
to
bfde98c
Compare
Hi @samuelmale |
kajambiya
force-pushed
the
petienrIfentifier
branch
2 times, most recently
from
3b6db1b
to
b860f08
Compare
|
@kajambiya You can test the validation aspect using this question from the AMPATH HTS Initial Form. |
|
So, as mentioned in the demos earlier today, the two expectations would be that:
|
kajambiya
force-pushed
the
petienrIfentifier
branch
2 times, most recently
from
b482677
to
b9cd626
Compare
kajambiya
force-pushed
the
petienrIfentifier
branch
from
b9cd626
to
2a396a1
Compare
Hi @denniskigen |
kajambiya
force-pushed
the
petienrIfentifier
branch
from
f00d670
to
d925324
Compare
|
@kajambiya please add some sample json on how someone can use this. It will help in the documentation |
pirupius
approved these changes
Apr 25, 2024
arodidev
pushed a commit
to arodidev/openmrs-form-engine-lib
that referenced
this pull request
Apr 29, 2024
…penmrs#202) * Add support for saving patient identifiers in forms * Address review comments * resolve conflicts * fix failing tests
samuelmale
added a commit
that referenced
this pull request
May 1, 2024
* resolving logic * Failsafe incase display object doesn't exist * Failsafe incase display object doesn't exist * linting * (feat) O3-3007: Add support for saving patient identifiers in forms (#202) * Add support for saving patient identifiers in forms * Address review comments * resolve conflicts * fix failing tests * (feat) O3-3109 deprecate type within inbuiltControls (#229) * (test) Fix intermittently failing tests (#231) * (feat) Update AFE transformer to handle aliases (#221) * (chore) Switch @carbon/react to peer dependency (#236) * (fix) fix tooltip alignment on obsGroup (#235) * fix tooltip styles on obsGroup * cleanup * (feat) Fetch all concept references of the the form with SWR Infinite (#241) * Fetching all concepts references with useSWRInfinite * Fixed failing tests * Failsafe incase display object doesn't exist * linting --------- Co-authored-by: Jovan Ssebaggala <jssebaggala@outlook.com> Co-authored-by: Pius Rubangakene <piruville@gmail.com> Co-authored-by: Samuel Male <samuelsmalek@gmail.com> Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces support to save patient identifier as part of a form. At form submission, the identifier is added to the patient's identifiers.
Screenshots
Screen.Recording.2024-04-24.at.17.19.08.mov
Related Issue
Other